I was a smoker brionon but mid July found out I was pregnant and so quit so I can see it from both sides :-)
My hubby still smokes and was totally anti-ban, he's a die-hard (literally, haha) smoker and feels the govt were taking away his right to smoke, yadda yadda. I, however, was looking forward to it, even as a smoker as I didn't enjoy getting in and smelling like an ashtray, and after a short stay in Cork last year I really enjoyed the social aspect of going outside and mixing with people whom I wouldn't normally speak to inside a pub.
Surprisingly though, my hubby has gone the other direction (although this might change when winter really hits us) and he doesn't mind going out for a cigarette; he doesn't smell so bad and he doesn't smoke so much so it's win-win as far as he (and I) is concerned.
I have heard a lot about the smells in pubs now (BO, etc) but I haven't noticed this myself, but then I don't go out that often, and I would imagine that night clubs probably honk but,again, I haven't been in one since the ban.